Add swift-testing support to the xctest runner #2554
+189
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed-irl
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
aaronsky
approved these changes
Dec 15, 2024
|
@aaronsky FYI I'm not able to merge (Github says "Only those with write access to this repository can merge pull requests"). If someone with write access wants to hit the merge button that'd be sweet :). |
|
Just waiting on one more review. Thank you for your patience 🙏🏼 |
karim-alweheshy
approved these changes
Dec 28, 2024
| test_target_execution_count=$(grep -e "Executed [[:digit:]]\{1,\} tests*," "$testlog" | tail -n1) | ||
| if echo "$test_target_execution_count" | grep -q -e "Executed 0 tests, with 0 failures"; then | ||
| xctest_target_execution_count=$(grep -e "Executed [[:digit:]]\{1,\} tests*," "$testlog" | tail -n1) | ||
| swift_testing_target_execution_count=$(grep -e "Test run with [[:digit:]]\{1,\} test" "$testlog" | tail -n1 || true) |
There was a problem hiding this comment.
Suggested change
| swift_testing_target_execution_count=$(grep -e "Test run with [[:digit:]]\{1,\} test" "$testlog" | tail -n1 || true) | |
| swift_testing_target_execution_count=$(grep -e "Test run with [[:digit:]]\{1,\} tests" "$testlog" | tail -n1 || true) |
| no_tests_ran=true | ||
| fi | ||
|
|
||
| if echo "$xctest_target_execution_count" | grep -q -e "Executed 0 tests, with 0 failures" && \ |
There was a problem hiding this comment.
can it be the case that only Testing targets ran with zero tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for swift-testing tests by checking for both the swift testing output as well as the normal xctest output.